Fix CloudTrail handling of custom policy URLs. #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the CloudTrail customizations to stop making HTTP requests to fetch custom policies, instead relying on the updated behavior of the CLI to automatically handle file and URL parameters for custom commands. Before this fix, the CLI would fetch the data into a string, then the CloudTrail customization would try to fetch the string as if it were a URL, fail, and throw an error.
|
I like this change. Can you add a test that uses the To create the custom policy in a local file, you can create a temp file with |
| f.write('{"Statement": []}') | ||
| command = ( | ||
| 'cloudtrail create-subscription --s3-use-bucket foo ' | ||
| '--name bar --s3-custom-policy file://{0}'.format(f.name)) |
There was a problem hiding this comment.
I agree with Kyle here. Let's verify that the policy we pass into the botocore layer is the value we expect.
|
Thanks! 🚢 |
|
|
danielgtaylor
added a commit
that referenced
this pull request
Mar 18, 2015
Fix CloudTrail handling of custom policy URLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the CloudTrail customizations to stop making HTTP requests
to fetch custom policies, instead relying on the updated behavior of the
CLI to automatically handle file and URL parameters for custom commands.
Before this fix, the CLI would fetch the data into a string, then the
CloudTrail customization would try to fetch the string as if it were
a URL, fail, and throw an error.
cc @jamesls @kyleknap